Skip to content

Changes to sdpa and attention module to support vision encoder attent… #7350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tarun292 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Changes to sdpa and attention module to support vision encoder attent… #7350

tarun292 wants to merge 1 commit into from

Conversation

@tarun292
Copy link
Contributor

@tarun292 tarun292 commented Dec 18, 2024

…ion with no kv-cache

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7350

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit e5fdb66 with merge base 68c0208 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2024
@tarun292 tarun292 force-pushed the tkaruturi/vision_encoder_et branch from 30aec3e to 05c1aa2 Compare January 4, 2025 00:45
@tarun292 tarun292 force-pushed the tkaruturi/vision_encoder_et branch 5 times, most recently from 9d7de2d to ac896e1 Compare January 6, 2025 21:34
@tarun292 tarun292 force-pushed the tkaruturi/vision_encoder_et branch from ac896e1 to e5fdb66 Compare January 6, 2025 21:39
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 31, 2025

Hi @tarun292!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng will be requested when the pull request is marked ready for review jackzhxng is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 will be requested when the pull request is marked ready for review larryliu0820 is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin will be requested when the pull request is marked ready for review mergennachin is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq will be requested when the pull request is marked ready for review lucylq is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarun292 @facebook-github-bot